[
https://issues.apache.org/jira/browse/CASSANDRA-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651814#comment-15651814
]
Joel Knighton commented on CASSANDRA-12273:
-------------------------------------------
Thanks for the patch [~muru]! Your approach looks sound.
A very similar issue exists on trunk with hdrfile logging if an {{hdrfile}} is
specified in {{SettingsLog.java}}. If you're interested, I think it makes a lot
of sense to also fix that problem as part of this ticket, as people affected by
this issue will likely also be affected by the fact that hdrfile paths do not
have their directory created. I also think it makes sense to canonicalize the
path before {{Files.createDirectories}}, since this would avoid needing to
special-case symlinks. This could be done by using {{getCanonicalPath}} instead
of {{toURI}}.
For future patches, it is easier to accept contributions if they include a
CHANGES.txt entry and an appropriately formatted commit message in a patch
created with {[git format-patch}}. The details on this are available in the
[docs|http://cassandra.apache.org/doc/latest/development/patches.html].
If you aren't interested in updating the patch with these changes, I still
think this patch is worth merging and will update this issue with an
appropriately formatted commit and will approve it after CI.
> Casandra stess graph: option to create directory for graph if it doesn't exist
> ------------------------------------------------------------------------------
>
> Key: CASSANDRA-12273
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12273
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Christopher Batey
> Assignee: Murukesh Mohanan
> Priority: Minor
> Labels: lhf
> Attachments: 12273.patch
>
>
> I am running it in CI with ephemeral workspace / build dirs. It would be
> nice if CS would create the directory so my build tool doesn't have to
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
