[
https://issues.apache.org/jira/browse/CASSANDRA-12792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15673013#comment-15673013
]
Branimir Lambov commented on CASSANDRA-12792:
---------------------------------------------
The 3.0+ version looks great.
One little nit on the 2.2: you can use
{{Predicates.alwaysTrue()/alwaysFalse()}} for most of the anonymous inner
classes.
> delete with timestamp long.MAX_VALUE for the whole key creates tombstone that
> cannot be removed.
> -------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-12792
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12792
> Project: Cassandra
> Issue Type: Bug
> Components: Compaction
> Reporter: Ian Ilsley
> Assignee: Joel Knighton
>
> In db/compaction/LazilyCompactedRow.java
> we only check for < MaxPurgeableTimeStamp
> eg:
> (this.maxRowTombstone.markedForDeleteAt < getMaxPurgeableTimestamp())
> this should probably be <=
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
