[ 
https://issues.apache.org/jira/browse/CASSANDRA-12934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15683619#comment-15683619
 ] 

Sylvain Lebresne commented on CASSANDRA-12934:
----------------------------------------------

+1 (for the records, it does indeed no seem to have affect anything currently 
because it affects the message payload size, and said side is only use for 
serializers that extend {{MessagingService.CallbackDeterminedSerializer}}, 
which is not the case).

Nit: in the {{equals}} methods, there is no need to test for {{null}} at the 
top of the methods since {{null instanceof X}} never returns {{true}}.

> AnticompactionRequestSerializer serializedSize is incorrect
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-12934
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12934
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Jason Brown
>            Assignee: Jason Brown
>             Fix For: 3.0.x, 3.x
>
>
> {{AnticompactionRequestSerializer#serializedSize}} does not add the size of 
> the {{#successfulRanges}} list to the total byte count.
> This incorrectly calculated size shouldn't affect anything in the current 
> release AFAICT, but it is a blocker for CASSANDRA-8457.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to