Aleksey Yeschenko created CASSANDRA-12998:
---------------------------------------------
Summary: Remove a silly hint.isLive() check in HintsService.write()
Key: CASSANDRA-12998
URL: https://issues.apache.org/jira/browse/CASSANDRA-12998
Project: Cassandra
Issue Type: Bug
Components: Local Write-Read Paths
Reporter: Aleksey Yeschenko
Assignee: Aleksey Yeschenko
Priority: Trivial
Fix For: 3.0.x, 3.x
Somehow made it to the final version of the codebase, this can practically
never return false. The {{bufferPool.write()}} call should be unconditional.
{code}
public void write(Iterable<UUID> hostIds, Hint hint)
{
if (isShutDown)
throw new IllegalStateException("HintsService is shut down and
can't accept new hints");
// we have to make sure that the HintsStore instances get properly
initialized - otherwise dispatch will not trigger
catalog.maybeLoadStores(hostIds);
if (hint.isLive())
bufferPool.write(hostIds, hint);
StorageMetrics.totalHints.inc(size(hostIds));
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
