[ 
https://issues.apache.org/jira/browse/CASSANDRA-13033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Stupp updated CASSANDRA-13033:
-------------------------------------
       Resolution: Fixed
    Fix Version/s:     (was: 3.0.x)
                   3.10
                   3.0.11
           Status: Resolved  (was: Patch Available)

Thanks for the prompt review!

CI looks good - no failures related to this patch.

Added the comment and committed it as 
[7f668c6fe117f892cd79863fb9805ea5d5a2823c|https://github.com/apache/cassandra/commit/7f668c6fe117f892cd79863fb9805ea5d5a2823c]
 to [cassandra-3.0|https://github.com/apache/cassandra/tree/cassandra-3.0] and 
merged it up to trunk. 


> Thread local pools never cleaned up
> -----------------------------------
>
>                 Key: CASSANDRA-13033
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13033
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
>             Fix For: 3.0.11, 3.10
>
>
> Netty 4.x uses {{(Fast)ThreadLocal}} instances to provide a pool of (direct) 
> buffers per thread 
> ({{io.netty.buffer.PooledByteBufAllocator.PoolThreadLocalCache}}. However, 
> these per-thread pools need to be cleaned up when a thread terminates 
> ({{FastThreadLocal.removeAll()}}) - which is missing.
> Although the possibility that such per-thread pools ever _need_ to be cleaned 
> up, since we rarely terminate threads, it still may actually happen and 
> manifest in a late and hard to detect out-of-memory situation. One 
> possibility to raise such a scenario is to regularly stop and restart the 
> native protocol service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to