[
https://issues.apache.org/jira/browse/CASSANDRA-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15744492#comment-15744492
]
Branimir Lambov commented on CASSANDRA-13035:
---------------------------------------------
Fix looks good, I don't see any other problems with the flag.
The problem doesn't look benign, though, this constructor is heavily used. The
class as it stands is a weird mixture of mutators and copiers -- I would prefer
to make this a builder-immutable pair (in a separate ticket); having the flag
final would have prevented the type of error we see here.
> Failing CDC unit tests
> ----------------------
>
> Key: CASSANDRA-13035
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13035
> Project: Cassandra
> Issue Type: Bug
> Reporter: Joshua McKenzie
> Assignee: Joshua McKenzie
> Attachments: 0001-Fix-missing-cdc-flag-on-Mutation-creation.patch
>
>
> CDC unit tests have been failing for a bit. There's a Mutation constructor
> used in tests that's missing cdc flagging on init w/a series of
> PartitionUpdates.
> Also seems to be missing from Mutation.without. The former is fixed in
> CASSANDRA-12148 and the latter I think I missed, but backporting now to get
> utests cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
