[ 
https://issues.apache.org/jira/browse/CASSANDRA-8780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15771303#comment-15771303
 ] 

Ben Slater commented on CASSANDRA-8780:
---------------------------------------

Hmm, still not sure we're on the same page here. The KS and Table from the yaml 
are still used the same as in the existing implementation. They are only added 
to the command line to link up the ops specified there with the relevant yaml 
spec. 

If only one table is being stressed (one yaml spec file) then you can actually 
leave out the ks and table on the command line and the single yaml file will 
automatically be used (to maintain backwards compatibility and simplicity in 
the single table case).

Where multiple yamls are specified, we can't assume that op names will be 
unique across yamls (insert, for example) so there needs to be some 
qualification of the ops specified on the command line to link them to the yaml 
file. I chose to use ks.table as this qualifier as it seemed to me like a 
pretty natural link. The alternatives I can see would be either (a) introduce a 
new, arbitrary spec name in the yaml file and use that to qualify the op names 
on the command line , (b) qualify the ops with some part of the yaml file name 
or (c) require op names to be globally unique across multiple yaml files. To 
me, I still think ks.table is the best of the alternatives for the qualifier 
but I'm happy to be persuaded otherwise.

I did notice on looking through the code again that I did a poor to 
non-existent job of handling the case where someone specifies a ks.table that's 
not in a yaml file so will update the code (and rebase) for that once we get 
this point agreed.

> cassandra-stress should support multiple table operations
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-8780
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8780
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Benedict
>            Assignee: Ben Slater
>              Labels: stress
>             Fix For: 3.x
>
>         Attachments: 8780-trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to