[
https://issues.apache.org/jira/browse/CASSANDRA-12990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15779943#comment-15779943
]
Branimir Lambov commented on CASSANDRA-12990:
---------------------------------------------
Code looks good.
Nit: [this
message|https://github.com/DikangGu/cassandra/commit/76532058c950a53ef8e92e562556e2d59745fde8#diff-8be666c70553b1f0017a01458c490f47R1622]
is not correct for the token allocation case.
> More fixes to the TokenAllocator
> --------------------------------
>
> Key: CASSANDRA-12990
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12990
> Project: Cassandra
> Issue Type: Bug
> Reporter: Dikang Gu
> Assignee: Dikang Gu
> Fix For: 3.12
>
>
> CASSANDRA-12983 fixes the NoReplicationTokenAllocator in the replication
> factor equals 0 case.
> We find one more problem that, in our big cluster, ~1000 nodes, the Gossip
> takes longer time to settle down, so the TokenAllocator may throw NPE when
> trying to find the dc rack information from the Gossip metadata, in the
> getStrategy function.
> This patch will fix it, it does two things:
> 1. wait gossip to settle down before trying to allocating tokens.
> 2. for replication factor equals 0 or 1 case, we do not need to check the
> topology for rack information, since each node will be treated separately.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
