[ 
https://issues.apache.org/jira/browse/CASSANDRA-13018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796372#comment-15796372
 ] 

Jason Brown commented on CASSANDRA-13018:
-----------------------------------------

[~brandon.williams] Thanks for the info and the link to the ticket.

If we decide to keep the log message, I think it's in the wrong place. 
Currently, it's in the block that starts with {{if(maxTargetVersion == 
NO_VERSION)}}, and that will only occur when we fail to connect to the peer. In 
that case the log message would read: {{Seed gossip version is -2147483648; 
will not connect with that version}}, where "-2147483648" is 
{{Integer.MIN_VALUE}}. I think this log message is more correctly placed in the 
{{if (targetVersion > maxTargetVersion)}} block, because then we've connected 
to and received the peer's messaging protocol version. WDYT?

In either case, [~jjirsa]'s exception checking code should be added. I just 
want to make sure the actual thing it's guarding is executed in the correct 
place.

> Exceptions encountered calling getSeeds() breaks messaging service
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-13018
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13018
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Streaming and Messaging
>            Reporter: Jeff Jirsa
>            Assignee: Jeff Jirsa
>              Labels: lhf
>         Attachments: 
> 0001-Better-handle-config-errors-during-outbound-connecti.patch
>
>
> OutboundTcpConnection.connect() calls getSeeds(). If getSeeds() throws an 
> exception (for example, DD/Config invalid yaml error), messaging thread(s) 
> break(s). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to