[ 
https://issues.apache.org/jira/browse/CASSANDRA-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003517#comment-13003517
 ] 

Vivek Mishra commented on CASSANDRA-2259:
-----------------------------------------

+1 for change.Modifying and reusing method is good thing.


Only thing is if we only column Family in validateColumnData() method. Then we 
can avoid : 

validateColumnData(keyspace, new ColumnParent(cfName), cosc.column); (creating 
ColumnParent instance). 
in validateColumnOrSuperColumn() method.

> column values are only being validated in insert()
> --------------------------------------------------
>
>                 Key: CASSANDRA-2259
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2259
>             Project: Cassandra
>          Issue Type: Bug
>          Components: API
>    Affects Versions: 0.7.0
>            Reporter: Eric Evans
>            Assignee: Jonathan Ellis
>             Fix For: 0.7.4
>
>         Attachments: 2259-v2.txt, CASSANDRA-2259_v1.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> insert() is the only code path that currently results in validate() being 
> called for column values; it is possible to write invalid column values using 
> batch_mutate()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to