[ 
https://issues.apache.org/jira/browse/CASSANDRA-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15863235#comment-15863235
 ] 

Joel Knighton commented on CASSANDRA-11479:
-------------------------------------------

More on my plate than Yuki's, I believe. The patch made sense to me, but I was 
waiting for a chance to dig deeper into the related compaction code before 
giving it a final OK. In the process, it slipped through the cracks quite 
badly. I'd be happy to do that, but it likely wouldn't happen in the next few 
days if you're interested in taking it on instead.

> BatchlogManager unit tests failing on truncate race condition
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-11479
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11479
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Compaction
>            Reporter: Joel Knighton
>            Assignee: Yuki Morishita
>             Fix For: 2.2.x, 3.0.x, 3.11.x
>
>         Attachments: 
> TEST-org.apache.cassandra.batchlog.BatchlogManagerTest.log
>
>
> Example on CI 
> [here|http://cassci.datastax.com/job/trunk_testall/818/testReport/junit/org.apache.cassandra.batchlog/BatchlogManagerTest/testLegacyReplay_compression/].
>  This seems to have only started happening relatively recently (within the 
> last month or two).
> As far as I can tell, this is only showing up on BatchlogManagerTests purely 
> because it is an aggressive user of truncate. The assertion is hit in the 
> setUp method, so it can happen before any of the test methods. The assertion 
> occurs because a compaction is happening when truncate wants to discard 
> SSTables; trace level logs suggest that this compaction is submitted after 
> the pause on the CompactionStrategyManager.
> This should be reproducible by running BatchlogManagerTest in a loop - it 
> takes up to half an hour in my experience. A trace-level log from such a run 
> is attached - grep for my added log message "SSTABLES COMPACTING WHEN 
> DISCARDING" to find when the assert is hit.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to