[
https://issues.apache.org/jira/browse/CASSANDRA-13002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876894#comment-15876894
]
Jon Haddad edited comment on CASSANDRA-13002 at 2/21/17 10:39 PM:
------------------------------------------------------------------
I don't believe this patch correctly handles upgrading from previous versions.
To test this, I built off the cassandra-3.0 branch, and loaded the movielens
dataset using {{cdm}} https://github.com/rustyrazorblade/cdm
I shut down the server, ran {{ant clean}} and {{ant}}, then restarted. The
server immediately died with this at the end of the logs:
{code}INFO [main] 2017-02-21 14:34:30,438 ColumnFamilyStore.java:419 -
Initializing system_schema.views
INFO [main] 2017-02-21 14:34:30,448 ColumnFamilyStore.java:419 - Initializing
system_schema.types
INFO [main] 2017-02-21 14:34:30,458 ColumnFamilyStore.java:419 - Initializing
system_schema.functions
INFO [main] 2017-02-21 14:34:30,469 ColumnFamilyStore.java:419 - Initializing
system_schema.aggregates
INFO [main] 2017-02-21 14:34:30,481 ColumnFamilyStore.java:419 - Initializing
system_schema.indexes
INFO [main] 2017-02-21 14:34:30,488 ViewManager.java:125 - Not submitting
build tasks for views in keyspace system_schema as storage service is not
initialized
Exception (java.lang.NullPointerException) encountered during startup: null
java.lang.NullPointerException
at
org.apache.cassandra.serializers.Int32Serializer.deserialize(Int32Serializer.java:31)
at
org.apache.cassandra.serializers.Int32Serializer.deserialize(Int32Serializer.java:25)
at
org.apache.cassandra.db.marshal.AbstractType.compose(AbstractType.java:116)
at
org.apache.cassandra.cql3.UntypedResultSet$Row.getInt(UntypedResultSet.java:287)
at
org.apache.cassandra.schema.SchemaKeyspace.createTableParamsFromRow(SchemaKeyspace.java:987)
at
org.apache.cassandra.schema.SchemaKeyspace.fetchTable(SchemaKeyspace.java:961)
at
org.apache.cassandra.schema.SchemaKeyspace.fetchTables(SchemaKeyspace.java:928)
at
org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspace(SchemaKeyspace.java:887)
at
org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspacesWithout(SchemaKeyspace.java:878)
at
org.apache.cassandra.schema.SchemaKeyspace.fetchNonSystemKeyspaces(SchemaKeyspace.java:866)
at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:113)
at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:103)
at
org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:238)
at
org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:557)
at
org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:646)
ERROR [main] 2017-02-21 14:34:30,562 CassandraDaemon.java:663 - Exception
encountered during startup
java.lang.NullPointerException: null
at
org.apache.cassandra.serializers.Int32Serializer.deserialize(Int32Serializer.java:31)
~[main/:na]
at
org.apache.cassandra.serializers.Int32Serializer.deserialize(Int32Serializer.java:25)
~[main/:na]
at
org.apache.cassandra.db.marshal.AbstractType.compose(AbstractType.java:116)
~[main/:na]
at
org.apache.cassandra.cql3.UntypedResultSet$Row.getInt(UntypedResultSet.java:287)
~[main/:na]
at
org.apache.cassandra.schema.SchemaKeyspace.createTableParamsFromRow(SchemaKeyspace.java:987)
~[main/:na]
at
org.apache.cassandra.schema.SchemaKeyspace.fetchTable(SchemaKeyspace.java:961)
~[main/:na]
at
org.apache.cassandra.schema.SchemaKeyspace.fetchTables(SchemaKeyspace.java:928)
~[main/:na]
at
org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspace(SchemaKeyspace.java:887)
~[main/:na]
at
org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspacesWithout(SchemaKeyspace.java:878)
~[main/:na]
at
org.apache.cassandra.schema.SchemaKeyspace.fetchNonSystemKeyspaces(SchemaKeyspace.java:866)
~[main/:na]
at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:113)
~[main/:na]
at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:103)
~[main/:na]
at
org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:238)
[main/:na]
at
org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:557)
[main/:na]
at
org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:646)
[main/:na]{code}
Also this patch is missing user documentation explaining the new feature.
was (Author: rustyrazorblade):
I don't believe this patch correctly handles upgrading from previous versions.
To test this, I built off the cassandra-3.0 branch, and loaded the movielens
dataset using {{cdm}} https://github.com/rustyrazorblade/cdm
I shut down the server, ran {{ant clean}} and {{ant}}, then restarted. The
server immediately died with this at the end of the logs:
{code}INFO [main] 2017-02-21 14:34:30,438 ColumnFamilyStore.java:419 -
Initializing system_schema.views
INFO [main] 2017-02-21 14:34:30,448 ColumnFamilyStore.java:419 - Initializing
system_schema.types
INFO [main] 2017-02-21 14:34:30,458 ColumnFamilyStore.java:419 - Initializing
system_schema.functions
INFO [main] 2017-02-21 14:34:30,469 ColumnFamilyStore.java:419 - Initializing
system_schema.aggregates
INFO [main] 2017-02-21 14:34:30,481 ColumnFamilyStore.java:419 - Initializing
system_schema.indexes
INFO [main] 2017-02-21 14:34:30,488 ViewManager.java:125 - Not submitting
build tasks for views in keyspace system_schema as storage service is not
initialized
Exception (java.lang.NullPointerException) encountered during startup: null
java.lang.NullPointerException
at
org.apache.cassandra.serializers.Int32Serializer.deserialize(Int32Serializer.java:31)
at
org.apache.cassandra.serializers.Int32Serializer.deserialize(Int32Serializer.java:25)
at
org.apache.cassandra.db.marshal.AbstractType.compose(AbstractType.java:116)
at
org.apache.cassandra.cql3.UntypedResultSet$Row.getInt(UntypedResultSet.java:287)
at
org.apache.cassandra.schema.SchemaKeyspace.createTableParamsFromRow(SchemaKeyspace.java:987)
at
org.apache.cassandra.schema.SchemaKeyspace.fetchTable(SchemaKeyspace.java:961)
at
org.apache.cassandra.schema.SchemaKeyspace.fetchTables(SchemaKeyspace.java:928)
at
org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspace(SchemaKeyspace.java:887)
at
org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspacesWithout(SchemaKeyspace.java:878)
at
org.apache.cassandra.schema.SchemaKeyspace.fetchNonSystemKeyspaces(SchemaKeyspace.java:866)
at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:113)
at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:103)
at
org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:238)
at
org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:557)
at
org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:646)
ERROR [main] 2017-02-21 14:34:30,562 CassandraDaemon.java:663 - Exception
encountered during startup
java.lang.NullPointerException: null
at
org.apache.cassandra.serializers.Int32Serializer.deserialize(Int32Serializer.java:31)
~[main/:na]
at
org.apache.cassandra.serializers.Int32Serializer.deserialize(Int32Serializer.java:25)
~[main/:na]
at
org.apache.cassandra.db.marshal.AbstractType.compose(AbstractType.java:116)
~[main/:na]
at
org.apache.cassandra.cql3.UntypedResultSet$Row.getInt(UntypedResultSet.java:287)
~[main/:na]
at
org.apache.cassandra.schema.SchemaKeyspace.createTableParamsFromRow(SchemaKeyspace.java:987)
~[main/:na]
at
org.apache.cassandra.schema.SchemaKeyspace.fetchTable(SchemaKeyspace.java:961)
~[main/:na]
at
org.apache.cassandra.schema.SchemaKeyspace.fetchTables(SchemaKeyspace.java:928)
~[main/:na]
at
org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspace(SchemaKeyspace.java:887)
~[main/:na]
at
org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspacesWithout(SchemaKeyspace.java:878)
~[main/:na]
at
org.apache.cassandra.schema.SchemaKeyspace.fetchNonSystemKeyspaces(SchemaKeyspace.java:866)
~[main/:na]
at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:113)
~[main/:na]
at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:103)
~[main/:na]
at
org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:238)
[main/:na]
at
org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:557)
[main/:na]
at
org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:646)
[main/:na]{code}
> per table slow query times
> --------------------------
>
> Key: CASSANDRA-13002
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13002
> Project: Cassandra
> Issue Type: New Feature
> Reporter: Jon Haddad
> Assignee: Murukesh Mohanan
> Fix For: 4.x
>
> Attachments:
> 0001-Add-per-table-slow_query_log_timeout_in_ms-property.patch
>
>
> CASSANDRA-12403 made it possible to log slow queries, but the time specified
> is a global one. This isn't useful if we know different tables have
> different access patterns, as we'll end up with a lot of noise. We should be
> able to override the slow query time at a per table level.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
