[ 
https://issues.apache.org/jira/browse/CASSANDRA-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887945#comment-15887945
 ] 

Benjamin Roth commented on CASSANDRA-13226:
-------------------------------------------

I am referring to this "stacktrace":

RepairMessageVerbHandler.doVerb (case VALIDATION_REQUEST)
CompactionManager.instance.submitValidation(store, validator) 
CompactionManager.doValidationCompaction
=> StorageService.instance.forceKeyspaceFlush

After that merkle trees are calculated and based on that streams are triggered. 
Thats why all data that is electable for transfer has already been flushed.

Also avoiding a flush locally is only the half way. Streams REQUESTED by a 
stream plan also cause a flush on the sender side. But that sender also has 
already validated (and so flushed) the requested data.

Maybe I missed sth but from what I can see, a REPAIR stream never requires a 
flush.

> StreamPlan for incremental repairs flushing memtables unnecessarily
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-13226
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13226
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>            Priority: Minor
>             Fix For: 4.0
>
>
> Since incremental repairs are run against a fixed dataset, there's no need to 
> flush memtables when streaming for them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to