[
https://issues.apache.org/jira/browse/CASSANDRA-13269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888103#comment-15888103
]
Andrés de la Peña commented on CASSANDRA-13269:
-----------------------------------------------
Adding support for snapshots in secondary indexes seems to me an useful
feature. I guess that the idea is that index snapshots would be cleared via
{{nodetool clearsnapshot}} only if the index implementation stores them in the
same directories where the base table snapshots are stored, isn't it?
Regarding the implementation:
- A default implementation of {{Index.getSnapshotWithoutFlushTask}} returning
null (or maybe Optional.empty()) would make it backwards compatible with
existing implementations, as it was done with {{Index.validate(ReadCommand)}}.
- I think that the addition of the set of indexes in {{SecondaryIndexManager}}
is probably out of the scope of this ticket and could have its own ticket,
don't you think so?
- It would be useful to add some tests. {{CustomIndexTest}} seems a good place
to place them.
- {{StubIndex.getSnapshotWithoutFlushTask}} has an autogenerated implementation
with a TODO comment about it.
- Braces placement doesn't satisfy the [code
style|https://wiki.apache.org/cassandra/CodeStyle].
[~jjirsa], maybe someone more familiarised with ColumnFamilyStore and
snapshots, and with access to the CI system, should take a look at it.
> Snapshot support for custom secondary indices
> ---------------------------------------------
>
> Key: CASSANDRA-13269
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13269
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: vincent royer
> Priority: Trivial
> Labels: features
> Fix For: 3.0.12, 3.11.0
>
> Attachments: 0001-CASSANDRA-13269-custom-indices-snapshot.patch
>
>
> Enhance the index API to support snapshot of custom secondary indices.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
