[ 
https://issues.apache.org/jira/browse/CASSANDRA-13333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937127#comment-15937127
 ] 

Michael Kjellman commented on CASSANDRA-13333:
----------------------------------------------

[~blerer] this looks great! Renaming {{CLibrary}} --> {{NativeLibrary}} helps 
make the intent much clearer. 

# Should the loading of {{Native.register("winmm")}} in {{WindowsTimer}} also 
be moved into NativeLibraryWindows?
# Looks like the trunk patch didn't get pushed up or potentially just a copy 
paste error? Currently it's just pointing at blerer/trunk.
# Thanks for putting the MSDN API URL in the method javadoc. :)
# In {{NativeLibraryWindows}} I think the following logger statements could be 
simplified:

{code}
catch (UnsatisfiedLinkError e)
{
    logger.warn("JNA link failure, one or more native method will be 
unavailable.");
    logger.error("JNA link failure details: {}", e.getMessage());
}
{code}

Can be simplified to:
{code}
logger.error("Failed to link against JNA. Native methods will be unavailable.", 
e);
{code}

> Cassandra does not start on Windows due to 'JNA link failure'
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-13333
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13333
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Benjamin Lerer
>            Assignee: Benjamin Lerer
>            Priority: Blocker
>
> Cassandra 3.0 HEAD does not start on Windows. The only error in the logs is: 
> {{ERROR 16:30:10 JNA failing to initialize properly.}} 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to