[ 
https://issues.apache.org/jira/browse/CASSANDRA-13452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Stupp updated CASSANDRA-13452:
-------------------------------------
    Reviewer: Robert Stupp

Nice catch! These overly careful {{finalizer()}} implementations are an awful 
relict.

The patch looks good to me, so I triggered CI. Some whitespace-noise though, 
but it's difficult to get around that - so I'm fine with that.

Feel free to ship it, if tests are all good (i.e. no regression).

||trunk|[branch|https://github.com/apache/cassandra/compare/trunk...snazy:13452-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-13452-trunk-testall/lastSuccessfulBuild/]|[dtest|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-13452-trunk-dtest/lastSuccessfulBuild/]


> Remove use of FileInputStream/FileOutputStream
> ----------------------------------------------
>
>                 Key: CASSANDRA-13452
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13452
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 4.0
>
>         Attachments: 13452.txt
>
>
> FileInputStream/FileOutputStream both suffer from the fact that they 
> implement finalize(), which means they gum up the gc until likely a full 
> garbage collection.
> Switch to using Files.newInputStream, Files.newOutputStream instead, which 
> don't have this problem



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to