[ 
https://issues.apache.org/jira/browse/CASSANDRA-13458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998297#comment-15998297
 ] 

Stefan Podkowinski commented on CASSANDRA-13458:
------------------------------------------------

[~bdeggleston], I was just reviewing your proposed guidelines on [what should 
be tested in a unit 
test|https://github.com/bdeggleston/cassandra/blob/testing-doc/TESTING.md#what-should-be-tested]
 and wonder if this ticket could be helpful for implementing listed test cases.

I've now added an example for testing error handling as well. Please see 
[testing.rst|https://github.com/spodkowinski/cassandra/blob/WIP-13458/doc/source/development/testing.rst#diagnostic-events-40]
 and {{testExceptionInPendingRangeCalc}} in 
[PendingRangeCalculatorServiceTest.java|https://github.com/spodkowinski/cassandra/blob/WIP-13458/test/unit/org/apache/cassandra/gms/PendingRangeCalculatorServiceTest.java]
 as example. Let me know if you have any ideas or comments.

> Diag. Events: Add unit testing support
> --------------------------------------
>
>                 Key: CASSANDRA-13458
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13458
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Testing
>            Reporter: Stefan Podkowinski
>            Assignee: Stefan Podkowinski
>
> Diagnostic events will improve unit testing by
> * providing test execution control instances based on CompletableFutures (see 
> [PendingRangeCalculatorServiceTest.java|https://github.com/spodkowinski/cassandra/blob/WIP-13458/test/unit/org/apache/cassandra/gms/PendingRangeCalculatorServiceTest.java])
>  
> * validate state and behavior by allowing you to inspect generated events 
> (see 
> [HintsServiceEventsTest.java|https://github.com/spodkowinski/cassandra/blob/WIP-13458/test/unit/org/apache/cassandra/hints/HintsServiceEventsTest.java])
> See included 
> [testing.rst|https://github.com/spodkowinski/cassandra/blob/WIP-13458/doc/source/development/testing.rst#diagnostic-events-40]
>  draft for more details. Let me know if this would be useful for you as a 
> developer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to