[
https://issues.apache.org/jira/browse/CASSANDRA-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031771#comment-16031771
]
Sergio Bossa commented on CASSANDRA-10130:
------------------------------------------
[~pauloricardomg], excellent suggestion.
[~adelapena], I personally like the "memtable" version more, as logically
speaking, if an sstable is added with a memtable, it means it has been also
indexed, while in all other cases it means the sstable(s) have been externally
loaded and needs indexing, but I have a few concerns:
1) There are too many overloads of {{addSSTable(s)}}, and some of them do not
make much sense and are there just to support self calls (i.e. the version with
many sstables and a single memtable I believe), so can we clean that up?
2) Who is actually calling the {{addSSTable}} method with the memtable? I think
I'm missing where it's actually used...
3) Why did you reduce the test coverage in
{{indexCorrectlyMarkedAsBuildAndRemoved}}?
> Node failure during 2i update after streaming can have incomplete 2i when
> restarted
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-10130
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10130
> Project: Cassandra
> Issue Type: Bug
> Components: Coordination
> Reporter: Yuki Morishita
> Assignee: Andrés de la Peña
> Priority: Minor
>
> Since MV/2i update happens after SSTables are received, node failure during
> MV/2i update can leave received SSTables live when restarted while MV/2i are
> partially up to date.
> We can add some kind of tracking mechanism to automatically rebuild at the
> startup, or at least warn user when the node restarts.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
