[ 
https://issues.apache.org/jira/browse/CASSANDRA-13570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcus Eriksson updated CASSANDRA-13570:
----------------------------------------
    Status: Patch Available  (was: Open)

> allow sub-range repairs (specifying -et -st) for a preview of repaired data
> ---------------------------------------------------------------------------
>
>                 Key: CASSANDRA-13570
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13570
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Matt Byrd
>            Assignee: Matt Byrd
>            Priority: Minor
>             Fix For: 4.x
>
>
> I don't see any inherent reason for restricting preview repairs of repaired 
> data to not allow specifying start and end tokens. 
> The restriction seems to be coming from the fact that incremental=true in 
> RepairOption, which is the case but it's not truly an incremental repair 
> since we're only previewing.
> {code:java}
>         if (option.isIncremental() && !option.isGlobal())
>         {
>             throw new IllegalArgumentException("Incremental repairs cannot be 
> run against a subset of tokens or ranges");
>         }
> {code}
> It would be helpful to allow this, so that operators could sequence a sweep 
> over the entirety of the token-space in a more gradual fashion.
> Also it might help in examining which portions of the token-space differ.
> Can anyone see any reasons for not allowing this?
> I.e just changing the above to something like:
> {code:java}
>  if (option.isIncremental() && !option.getPreviewKind().isPreview() && 
> !option.isGlobal())
>           {
>               throw new IllegalArgumentException("Incremental repairs cannot 
> be run against a subset of tokens or ranges");
>           }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to