[ 
https://issues.apache.org/jira/browse/CASSANDRA-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083477#comment-16083477
 ] 

Jay Zhuang commented on CASSANDRA-13655:
----------------------------------------

Tried the patch locally, looks good to me, a few minor comments:
1. Would it be better to combine {{SliceUpdate}} and {{RowUpdate}}?
2. How about having a function for these 3 checks (like 
{{ModificationStatement.hasSlices()}} or a better name): 
[BatchStatement.java:420 | 
https://github.com/jeffjirsa/cassandra/commit/b9a6be6f5fc867718907d1abae124137d4f1cb45#diff-bee3b2111122530d9e0c5190e6773f62R420]
 and here: [ModificationStatement.java:629| 
https://github.com/jeffjirsa/cassandra/blob/cassandra-3.0-13655/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java#L629]

> Range deletes in a CAS batch are ignored
> ----------------------------------------
>
>                 Key: CASSANDRA-13655
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13655
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CQL
>            Reporter: Jeff Jirsa
>            Assignee: Jeff Jirsa
>            Priority: Critical
>             Fix For: 3.0.x, 3.11.x, 4.x
>
>
> Range deletes in a CAS batch are ignored 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to