[ 
https://issues.apache.org/jira/browse/CASSANDRA-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096627#comment-16096627
 ] 

Marcus Eriksson commented on CASSANDRA-11483:
---------------------------------------------

Pushed a code style fixup here: 
https://github.com/krummas/cassandra/commits/clohfink/11483

comments:
* the TimeUnit for printing out min/max timestamps are not guaranteed to be 
micros, maybe the user should be able to override the TimeUnit.MICROSECONDS 
from the command line?
* should we collect the 
{{widestPartitions}}/{{largestPartitions}}/{{mostTombstones}} during 
compaction/flush and always show them? Would be quite useful to not have to 
scan the sstable for this info. We should probably do that in a new ticket 
though
* {{SSTable min local deletion time}} and {{SSTable max local deletion time}} 
needs to special-case Long.MAX_VALUE I think - if we don't have a deletion, we 
should probably indicate that in the output instead of outputting "01/18/2038 
19:14:07"

> Enhance sstablemetadata
> -----------------------
>
>                 Key: CASSANDRA-11483
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11483
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Observability
>            Reporter: Chris Lohfink
>            Assignee: Chris Lohfink
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: CASSANDRA-11483.txt, CASSANDRA-11483v2.txt, 
> CASSANDRA-11483v3.txt, CASSANDRA-11483v4.txt, CASSANDRA-11483v5.txt, Screen 
> Shot 2016-04-03 at 11.40.32 PM.png
>
>
> sstablemetadata provides quite a bit of useful information but theres a few 
> hiccups I would like to see addressed:
> * Does not use client mode
> * Units are not provided (or anything for that matter). There is data in 
> micros, millis, seconds as durations and timestamps from epoch. But there is 
> no way to tell what one is without a non-trival code dive
> * in general pretty frustrating to parse



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to