[ https://issues.apache.org/jira/browse/CASSANDRA-9375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097631#comment-16097631 ]
Jason Brown commented on CASSANDRA-9375: ---------------------------------------- [~varuna] I think you can use {{Math#max(int,int)}} to simplify the code. For example: {code}read_request_timeout_in_ms = read_request_timeout_in_ms < LOWEST_ACCEPTED_TIMEOUT ? LOWEST_ACCEPTED_TIMEOUT : read_request_timeout_in_ms{code} becomes {code}read_request_timeout_in_ms = Math.max(read_request_timeout_in_ms, LOWEST_ACCEPTED_TIMEOUT){code} Also, it might be nice to log if any of the operator's value's were too low, and we adjusted it up to the {{LOWEST_ACCEPTED_TIMEOUT}}. Not completely sure about this though ... > setting timeouts to 1ms prevents startup > ---------------------------------------- > > Key: CASSANDRA-9375 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9375 > Project: Cassandra > Issue Type: Improvement > Reporter: Brandon Williams > Priority: Trivial > Labels: patch > Fix For: 2.1.x > > Attachments: CASSANDRA-9375.patch > > > Granted, this is a nonsensical setting, but the error message makes it tough > to discern what's wrong: > {noformat} > ERROR 17:13:28,726 Exception encountered during startup > java.lang.ExceptionInInitializerError > at > org.apache.cassandra.net.MessagingService.instance(MessagingService.java:310) > at > org.apache.cassandra.service.StorageService.<init>(StorageService.java:233) > at > org.apache.cassandra.service.StorageService.<clinit>(StorageService.java:141) > at > org.apache.cassandra.locator.DynamicEndpointSnitch.<init>(DynamicEndpointSnitch.java:87) > at > org.apache.cassandra.locator.DynamicEndpointSnitch.<init>(DynamicEndpointSnitch.java:63) > at > org.apache.cassandra.config.DatabaseDescriptor.createEndpointSnitch(DatabaseDescriptor.java:518) > at > org.apache.cassandra.config.DatabaseDescriptor.applyConfig(DatabaseDescriptor.java:350) > at > org.apache.cassandra.config.DatabaseDescriptor.<clinit>(DatabaseDescriptor.java:112) > at > org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:213) > at > org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:567) > at > org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:656) > Caused by: java.lang.IllegalArgumentException > at > java.util.concurrent.ScheduledThreadPoolExecutor.scheduleWithFixedDelay(ScheduledThreadPoolExecutor.java:586) > at > org.apache.cassandra.concurrent.DebuggableScheduledThreadPoolExecutor.scheduleWithFixedDelay(DebuggableScheduledThreadPoolExecutor.java:64) > at org.apache.cassandra.utils.ExpiringMap.<init>(ExpiringMap.java:103) > at > org.apache.cassandra.net.MessagingService.<init>(MessagingService.java:360) > at org.apache.cassandra.net.MessagingService.<init>(MessagingService.java:68) > at > org.apache.cassandra.net.MessagingService$MSHandle.<clinit>(MessagingService.java:306) > ... 11 more > java.lang.ExceptionInInitializerError > at > org.apache.cassandra.net.MessagingService.instance(MessagingService.java:310) > at > org.apache.cassandra.service.StorageService.<init>(StorageService.java:233) > at > org.apache.cassandra.service.StorageService.<clinit>(StorageService.java:141) > at > org.apache.cassandra.locator.DynamicEndpointSnitch.<init>(DynamicEndpointSnitch.java:87) > at > org.apache.cassandra.locator.DynamicEndpointSnitch.<init>(DynamicEndpointSnitch.java:63) > at > org.apache.cassandra.config.DatabaseDescriptor.createEndpointSnitch(DatabaseDescriptor.java:518) > at > org.apache.cassandra.config.DatabaseDescriptor.applyConfig(DatabaseDescriptor.java:350) > at > org.apache.cassandra.config.DatabaseDescriptor.<clinit>(DatabaseDescriptor.java:112) > at > org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:213) > at > org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:567) > at > org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:656) > Caused by: java.lang.IllegalArgumentException > at > java.util.concurrent.ScheduledThreadPoolExecutor.scheduleWithFixedDelay(ScheduledThreadPoolExecutor.java:586) > at > org.apache.cassandra.concurrent.DebuggableScheduledThreadPoolExecutor.scheduleWithFixedDelay(DebuggableScheduledThreadPoolExecutor.java:64) > at org.apache.cassandra.utils.ExpiringMap.<init>(ExpiringMap.java:103) > at > org.apache.cassandra.net.MessagingService.<init>(MessagingService.java:360) > at org.apache.cassandra.net.MessagingService.<init>(MessagingService.java:68) > at > org.apache.cassandra.net.MessagingService$MSHandle.<clinit>(MessagingService.java:306) > ... 11 more > Exception encountered during startup: null > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org