[
https://issues.apache.org/jira/browse/CASSANDRA-13730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111331#comment-16111331
]
Aleksey Yeschenko commented on CASSANDRA-13730:
-----------------------------------------------
[~jasonstack] Looking good, only have one small nit: {{columnName.toString()}}
call is redundant, as {{columnName}} is already a string. Should remove that
call. Also, my (subjective) preference would be to pass {{DroppedColumn}} and
not {{String}} as {{columnName}} to {{dropDroppedColumnFromSchemaMutation()}}
method, for consistency with other similar methods in the class.
Unit test and dtest look good to me.
> Dropping a table doesn't drop its dropped columns
> -------------------------------------------------
>
> Key: CASSANDRA-13730
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13730
> Project: Cassandra
> Issue Type: Bug
> Components: Distributed Metadata
> Reporter: Duarte Nunes
> Assignee: ZhaoYang
> Priority: Minor
> Fix For: 3.0.x, 3.11.x
>
>
> I'm not sure if this is intended or not, but currently a table's dropped
> columns are not dropped when the table itself is dropped:
> {noformat}
> cqlsh> create keyspace ks WITH replication={ 'class' : 'SimpleStrategy',
> 'replication_factor' : 1 } ;
> cqlsh> use ks;
> cqlsh:ks> create table test (pk text primary key, c1 int);
> cqlsh:ks> alter table test drop c1;
> cqlsh:ks> drop table test;
> cqlsh:ks> select * from system_schema.dropped_columns where keyspace_name =
> 'ks' and table_name = 'test';
> keyspace_name | table_name | column_name | dropped_time |
> kind | type
> ---------------+------------+-------------+---------------------------------+---------+------
> ks | test | c1 | 2017-07-25 17:53:47.651000+0000 |
> regular | int
> (1 rows)
> {noformat}
> This can have surprising consequences when creating another table with the
> same name.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
