[
https://issues.apache.org/jira/browse/CASSANDRA-13799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146878#comment-16146878
]
Malcolm Taylor commented on CASSANDRA-13799:
--------------------------------------------
Addressing the following alerts, found by lgtm.com analysing trunk:
1) type mismatch on container access in SeedManager (this looks like a bug)
2) Class Bound overrides equals but not hashCode in Expression
3) Expression always evaluates to same value in Booleans (again, looks like a
bug)
4) Implicit narrowing conversion in Distribution
5) Two cases of dereferenced variable may be null, in FieldIdentifier and
RoleName
6) Six cases of possible confusion of local and field, in Seedmanager,
CompressionMetadata and TokenMetadata
7) Two cases of unused format arguments, in ColumnCondition and FunctionResolver
Also adding a test, which fails in trunk but passes with these changes
> Fix some alerts raised by lgtm.com
> ----------------------------------
>
> Key: CASSANDRA-13799
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13799
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Malcolm Taylor
> Assignee: Malcolm Taylor
>
> lgtm.com has identified a number of issues where there may be scope for
> improving the code
> ([https://lgtm.com/projects/g/apache/cassandra/alerts/?mode=tree&severity=error]).
> This issue is to address some of the more straightforward cases.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
