[
https://issues.apache.org/jira/browse/CASSANDRA-13883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172606#comment-16172606
]
ZhaoYang edited comment on CASSANDRA-13883 at 9/20/17 2:03 AM:
---------------------------------------------------------------
| source | unit | dtest |
|
[trunk|https://github.com/apache/cassandra/compare/trunk...jasonstack:CASSANDRA-13883-trunk?expand=1]|
[passed|https://circleci.com/gh/jasonstack/cassandra/627] |
repair_tests.repair_test.TestRepair.dc_parallel_repair_test
repair_tests.repair_test.TestRepair.dc_repair_test
repair_tests.repair_test.TestRepair.local_dc_repair_test
repair_tests.repair_test.TestRepair.simple_parallel_repair_test
repair_tests.repair_test.TestRepair.thread_count_repair_test
upgrade_internal_auth_test.TestAuthUpgrade.upgrade_to_22_test
upgrade_internal_auth_test.TestAuthUpgrade.upgrade_to_30_test
auth_test.TestAuth.system_auth_ks_is_alterable_test
disk_balance_test.TestDiskBalance.disk_balance_decommission_test
cdc_test.TestCDC.test_insertion_and_commitlog_behavior_after_reaching_cdc_total_space
cdc_test.TestCDC.test_insertion_and_commitlog_behavior_after_reaching_cdc_total_space|
|
[3.11|https://github.com/apache/cassandra/compare/cassandra-3.11...jasonstack:CASSANDRA-13883-3.11?expand=1]
| [passed|https://circleci.com/gh/jasonstack/cassandra/625] |
upgrade_internal_auth_test.TestAuthUpgrade.upgrade_to_22_test
upgrade_internal_auth_test.TestAuthUpgrade.upgrade_to_30_test
auth_test.TestAuth.system_auth_ks_is_alterable_test |
|
[3.0|https://github.com/apache/cassandra/compare/cassandra-3.0...jasonstack:CASSANDRA-13883-3.0?expand=1]
| [running|https://circleci.com/gh/jasonstack/cassandra/628]|
global_row_key_cache_test.TestGlobalRowKeyCache.functional_test
repair_tests.incremental_repair_test.TestIncRepair.multiple_repair_test
upgrade_internal_auth_test.TestAuthUpgrade.upgrade_to_22_test
upgrade_internal_auth_test.TestAuthUpgrade.upgrade_to_30_test |
|
[dtest|https://github.com/apache/cassandra-dtest/compare/master...jasonstack:CASSANDRA-13883?expand=1]
|
CI looks good, I will restart a few flaky ones.
{code}
Changes:
1. Change {{AbstractRow.hasLiveData}} to check {{enforceStrictLiveness}}:
if livenessInfo is not live and enforceStrictLiveness, then there is not live
data.
2. For SPRC.group, use the first command to get {{enforceStrictLiveness}}
since each command should be the same except for key.
{code}
was (Author: jasonstack):
| source | unit | dtest |
|
[trunk|https://github.com/apache/cassandra/compare/trunk...jasonstack:CASSANDRA-13883-trunk?expand=1]|
[passed|https://circleci.com/gh/jasonstack/cassandra/627] | |
|
[3.11|https://github.com/apache/cassandra/compare/cassandra-3.11...jasonstack:CASSANDRA-13883-3.11?expand=1]
| [passed|https://circleci.com/gh/jasonstack/cassandra/625] | |
|
[3.0|https://github.com/apache/cassandra/compare/cassandra-3.0...jasonstack:CASSANDRA-13883-3.0?expand=1]
| | |
|
[dtest|https://github.com/apache/cassandra-dtest/compare/master...jasonstack:CASSANDRA-13883?expand=1]
|
CI looks good, I will restart a few flaky ones.
{code}
Changes:
1. Change {{AbstractRow.hasLiveData}} to check {{enforceStrictLiveness}}:
if livenessInfo is not live and enforceStrictLiveness, then there is not live
data.
2. For SPRC.group, use the first command to get {{enforceStrictLiveness}}
since each command should be the same except for key.
{code}
> StrictLiveness for view row is not handled in AbstractRow
> ---------------------------------------------------------
>
> Key: CASSANDRA-13883
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13883
> Project: Cassandra
> Issue Type: Bug
> Components: Materialized Views
> Reporter: ZhaoYang
> Assignee: ZhaoYang
> Fix For: 3.0.15, 3.11.1, 4.0
>
>
> In {{AbstractRow.hasLiveData(nowInSecond)}}, it doesn't handle
> {{strictLiveness}} introduced in CASSANDRA-11500. The {{DataLimits}} counts
> the expired view row as live data and then the expired view row is purged in
> {{Row.purge()}}. When query with limit, we will get less data.
> {code:title=test to reproduce}
> @Test
> public void testRegularColumnTimestampUpdates() throws Throwable
> {
> createTable("CREATE TABLE %s (" +
> "k int PRIMARY KEY, " +
> "c int, " +
> "val int)");
> execute("USE " + keyspace());
> executeNet(protocolVersion, "USE " + keyspace());
> createView("mv_rctstest", "CREATE MATERIALIZED VIEW %s AS SELECT *
> FROM %%s WHERE k IS NOT NULL AND c IS NOT NULL PRIMARY KEY (k,c)");
> updateView("UPDATE %s SET c = ?, val = ? WHERE k = ?", 0, 0, 0);
> updateView("UPDATE %s SET val = ? WHERE k = ?", 1, 0);
> updateView("UPDATE %s SET c = ? WHERE k = ?", 1, 0);
> assertRows(execute("SELECT c, k, val FROM mv_rctstest"), row(1, 0,
> 1));
> updateView("TRUNCATE %s");
> updateView("UPDATE %s USING TIMESTAMP 1 SET c = ?, val = ? WHERE k =
> ?", 0, 0, 0);
> updateView("UPDATE %s USING TIMESTAMP 3 SET c = ? WHERE k = ?", 1, 0);
> updateView("UPDATE %s USING TIMESTAMP 2 SET val = ? WHERE k = ?", 1,
> 0);
> updateView("UPDATE %s USING TIMESTAMP 4 SET c = ? WHERE k = ?", 2, 0);
> updateView("UPDATE %s USING TIMESTAMP 3 SET val = ? WHERE k = ?", 2,
> 0);
> // FIXME no rows return
> assertRows(execute("SELECT c, k, val FROM mv_rctstest limit 1"),
> row(2, 0, 2));
> assertRows(execute("SELECT c, k, val FROM mv_rctstest"), row(2, 0,
> 2));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
