[ 
https://issues.apache.org/jira/browse/CASSANDRA-13909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183746#comment-16183746
 ] 

Stefania commented on CASSANDRA-13909:
--------------------------------------

LGTM - I only found 3 nits, see comments 
[here|https://github.com/krummas/cassandra/commit/9ea54dc47f75d0296dde4f74fd6f4d3de392f991].

There seem to be timeouts in both the dtests (they timed out on 
manual_join_test) and the unit tests. I doubt very much that they are related 
to this patch but the main 
[builds|https://builds.apache.org/view/A-D/view/Cassandra/] are not affected by 
timeouts (although they did not run in almost a month). I've verified that the 
unit test that timed out passes locally.

+1 to commit if you are sure that these timeouts are happening on other 
branches too.




> Improve TRUNCATE performance with many sstables
> -----------------------------------------------
>
>                 Key: CASSANDRA-13909
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13909
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>             Fix For: 3.0.x, 3.11.x, 4.x
>
>
> Truncate is very slow in 3.0, mostly due to {{LogRecord.make}} listing all 
> files in the directory for every sstable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to