[ 
https://issues.apache.org/jira/browse/CASSANDRA-13940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196081#comment-16196081
 ] 

Ben Slater commented on CASSANDRA-13940:
----------------------------------------

Just got a chance to take a look at this and I agree this is a much 
better/cleaner implementation than mine. Looking back at it I think the 
different multiplier values was only really necessary for the very small runs 
that I was initially testing on but are probably too small to be particularly 
relevant. I rechecked a few of my more realistic tests with the static 
multiplier and results were pretty similar.

So, no objection from me to this. Maybe @tjake can review as he reviewed the 
initial patch?

> Fix stress seed multiplier
> --------------------------
>
>                 Key: CASSANDRA-13940
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13940
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Stress
>            Reporter: Daniel Cranford
>         Attachments: 0001-Fixing-seed-multiplier.patch
>
>
> CASSANDRA-12744 attempted to fix a problem with partition key generation, but 
> is generally broken. E.G.
> {noformat}
> cassandra-stress -insert visits=fixed\(100\) revisit=uniform\(1..100\) ...
> {noformat}
> sends cassandra-stress into an infinite loop. Here's a better fix.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to