[
https://issues.apache.org/jira/browse/CASSANDRA-13425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227647#comment-16227647
]
Paulo Motta commented on CASSANDRA-13425:
-----------------------------------------
bq. Paulo Motta are you OK with this?
The renaming of {{setBestLevelsOn}} to {{prepareForAddition}} looks much nicer
now.
I'm just curious to what use case will this solve that a simple "insert where
it fits" would not solve? In a normal usage scenario there won't be holes in
the levels (afaik) - except for the last level perhaps - so it's not clear to
me where will this be useful to justify the extra complexity. I modified
{{prepareForAddition}} to "insert where it fits" and the test still passes, so
at the very least we should add a test case where this method will perform
better.
> nodetool refresh should try to insert new sstables in existing leveling
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-13425
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13425
> Project: Cassandra
> Issue Type: Bug
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Fix For: 4.x
>
>
> Currently {{nodetool refresh}} sets level to 0 on all new sstables, instead
> we could try to find gaps in the existing leveling and insert them there.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
