[
https://issues.apache.org/jira/browse/CASSANDRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248740#comment-16248740
]
Jay Zhuang commented on CASSANDRA-9988:
---------------------------------------
Thanks [~jasobrown] for the review.
bq. just to confirm, {{FullBTreeSearchIterator}} is just a rename of the
previous {{BTreeSearchIterator}} class? My diff'ing seems to confirm that, but
I'd like the extra level of sanity checking.
Yes.
bq. {{BTreeSet}} switch imports back to original format
Updated.
bq. in {{LeafBTreeSearchIterator}}, move {{#compareToFirst}} and
{{#searchNext}} closer to the methods from where they are called. Or better
yet, since each is only called from one place, just inline the functionality
into those calling methods.
Updated. Removed {{#compareToFirst}} and moved {{#searchNext}}
For microbench, I was running the same microbench test with and without the
patch. Having them in the same test would be easier to compare the test
results. Here is updated branch:
| Branch | uTest |
| [9988-update|https://github.com/cooldoger/cassandra/tree/9988-update] |
[!https://circleci.com/gh/cooldoger/cassandra/tree/9988-update.svg?style=svg!|https://circleci.com/gh/cooldoger/cassandra/tree/9988-update]
|
> Introduce leaf-only iterator
> ----------------------------
>
> Key: CASSANDRA-9988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9988
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Benedict
> Assignee: Jay Zhuang
> Priority: Minor
> Labels: patch
> Fix For: 4.0
>
> Attachments: 9988-3tests.png, 9988-data.png, 9988-result.png,
> 9988-result2.png, 9988-result3.png, 9988-test-result-expsearch.xlsx,
> 9988-test-result-raw.png, 9988-test-result.xlsx, 9988-test-result3.png,
> 9988-trunk-new-update.txt, 9988-trunk-new.txt, trunk-9988.txt
>
>
> In many cases we have small btrees, small enough to fit in a single leaf
> page. In this case it _may_ be more efficient to specialise our iterator.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
