[
https://issues.apache.org/jira/browse/CASSANDRA-13006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260876#comment-16260876
]
Joshua McKenzie commented on CASSANDRA-13006:
---------------------------------------------
Sorry for the delay - didn't realize I was reviewer on this.
Feedback follows:
general feedback:
- In our launch scripts, why have a separate JVM_ON_OUT_OF_MEMORY_ERROR_OPT
instead of nesting it inside JVM_OPTS? The latter seems more consistent w/other
configuration approaches. This would also clean up launching branch logic a
touch.
nits:
- Not sure why StartupChecks.checkOutOfMemoryHandling() is scoped to protected.
Should be able to be private.
- remove added whitespace at top of bin/cassandra.sh
- misspelling: {code} # uncomment the prefered option {code} should be
{{preferred}}
- Same holds for conf/cassandra-env.sh
- Having parseJavaVersion and parseUpdate both take no arguments and
System.getProperty("java.version") would be a cleaner interface. This isn't
critical path in any way so the duplicate calls to getProperty would be no real
issue.
- "jmcd" should read "jcmd" in comments in HeapUtils.java, line 55
- Since HeapUtils is the only call-site for {{logProcessOutput}}, that can be
inlined if you're in the mood for it.
Basically a bag of trivial things - looks good on the whole. +1 with the above
nits dealt with as you see fit.
> Disable automatic heap dumps on OOM error
> -----------------------------------------
>
> Key: CASSANDRA-13006
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13006
> Project: Cassandra
> Issue Type: Bug
> Components: Configuration
> Reporter: anmols
> Assignee: Benjamin Lerer
> Priority: Minor
> Attachments: 13006-3.0.9.txt
>
>
> With CASSANDRA-9861, a change was added to enable collecting heap dumps by
> default if the process encountered an OOM error. These heap dumps are stored
> in the Apache Cassandra home directory unless configured otherwise (see
> [Cassandra Support
> Document|https://support.datastax.com/hc/en-us/articles/204225959-Generating-and-Analyzing-Heap-Dumps]
> for this feature).
>
> The creation and storage of heap dumps aides debugging and investigative
> workflows, but is not be desirable for a production environment where these
> heap dumps may occupy a large amount of disk space and require manual
> intervention for cleanups.
>
> Managing heap dumps on out of memory errors and configuring the paths for
> these heap dumps are available as JVM options in JVM. The current behavior
> conflicts with the Boolean JVM flag HeapDumpOnOutOfMemoryError.
>
> A patch can be proposed here that would make the heap dump on OOM error honor
> the HeapDumpOnOutOfMemoryError flag. Users who would want to still generate
> heap dumps on OOM errors can set the -XX:+HeapDumpOnOutOfMemoryError JVM
> option.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
