[
https://issues.apache.org/jira/browse/CASSANDRA-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274417#comment-16274417
]
Jason Brown edited comment on CASSANDRA-13916 at 12/1/17 2:10 PM:
------------------------------------------------------------------
On trunk, the {{StartupCheck}} we have is:
{code}
String javaVmName = System.getProperty("java.vm.name");
if (javaVmName.contains("OpenJDK"))
{
// There is essentially no QA done on OpenJDK builds, and
// clusters running OpenJDK have seen many heap and load issues.
logger.warn("OpenJDK is not recommended. Please upgrade to the
newest Oracle Java release");
}
else if (!javaVmName.contains("HotSpot"))
{
logger.warn("Non-Oracle JVM detected. Some features, such as
immediate unmap of compacted SSTables, may not work as intended");
}
{code}
If we get rid of the OpenJDK check, I suspect users will start seeing the next
warning. OpenJDK's {{-version}} prints this:
{code}
java version "1.8.0_151"
Java(TM) SE Runtime Environment (build 1.8.0_151-b12)
Java HotSpot(TM) 64-Bit Server VM (build 25.151-b12, mixed mode)
{code}
Should we get rid of both checks? Or just the first? I'm no OpenJDK expert, so
I don't know if that second warning applies.
UPDATE: -I am unable read clearly, and the second warning will not be logged on
OpenJDK. I'll create a patch for this shortly.-
UPDATE 2: Ugh, this is gonna be a long day. Actual output of OpenJDK's
{{-version}} is:
{code}
openjdk version "1.8.0_151"
OpenJDK Runtime Environment (build 1.8.0_151-8u151-b12-0ubuntu0.17.10.2-b12)
OpenJDK 64-Bit Server VM (build 25.151-b12, mixed mode)
{code}
So, the operator would see the second warning
was (Author: jasobrown):
On trunk, the {{StartupCheck}} we have is:
{code}
String javaVmName = System.getProperty("java.vm.name");
if (javaVmName.contains("OpenJDK"))
{
// There is essentially no QA done on OpenJDK builds, and
// clusters running OpenJDK have seen many heap and load issues.
logger.warn("OpenJDK is not recommended. Please upgrade to the
newest Oracle Java release");
}
else if (!javaVmName.contains("HotSpot"))
{
logger.warn("Non-Oracle JVM detected. Some features, such as
immediate unmap of compacted SSTables, may not work as intended");
}
{code}
If we get rid of the OpenJDK check, I suspect users will start seeing the next
warning. OpenJDK's {{-version}} prints this:
{code}
java version "1.8.0_151"
Java(TM) SE Runtime Environment (build 1.8.0_151-b12)
Java HotSpot(TM) 64-Bit Server VM (build 25.151-b12, mixed mode)
{code}
Should we get rid of both checks? Or just the first? I'm no OpenJDK expert, so
I don't know if that second warning applies.
UPDATE: I am unable read clearly, and the second warning will not be logged on
OpenJDK. I'll create a patch for this shortly.
> Remove OpenJDK log warning
> --------------------------
>
> Key: CASSANDRA-13916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13916
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Anthony Grasso
> Priority: Minor
> Labels: lhf
>
> The following warning message will appear in the logs when using OpenJDK
> {noformat}
> WARN [main] ... OpenJDK is not recommended. Please upgrade to the newest
> Oracle Java release
> {noformat}
> The above warning dates back to when OpenJDK 6 was released and there were
> some issues in early releases of this version. The OpenJDK implementation is
> used as a reference for the OracleJDK which means the implementations are
> very close. In addition, most users have moved off Java 6 so we can probably
> remove this warning message.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
