[ 
https://issues.apache.org/jira/browse/CASSANDRA-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279458#comment-16279458
 ] 

ASF GitHub Bot commented on CASSANDRA-14091:
--------------------------------------------

Github user jeffjirsa commented on the issue:

    https://github.com/apache/cassandra/pull/178
  
    Hi @Benmartin92 , That looks like a perfectly reasonable patch. It appears 
that @bdeggleston also noticed this in 
https://issues.apache.org/jira/browse/CASSANDRA-14091 (a week or so after your 
patch). Unfortunately, I don't think anyone noticed your patch, probably 
because we don't typically use Github PRs (ASF repo isn't writable on github, 
so we can't merge this PR directly) - our contribution workflow is through 
JIRA. Appreciate the contribution, sorry we didn't see it in time. 


> DynamicSnitch creates a lot of garbage
> --------------------------------------
>
>                 Key: CASSANDRA-14091
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14091
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>             Fix For: 3.0.16, 3.11.2, 4.0
>
>
> The ExponentiallyDecayingReservoir snapshots we take during score updates 
> generate a lot of garbage, and we call getSnapshot twice per endpoint when we 
> only need to call it once.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to