[ 
https://issues.apache.org/jira/browse/CASSANDRA-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288056#comment-16288056
 ] 

Daniele Rolando commented on CASSANDRA-12208:
---------------------------------------------

[~krummas] Hey, I see that your patch is present in the [3.11 
branch|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/tools/SSTableMetadataViewer.java],
 however when I run the sstablemetadata binary that comes with 
cassandra-tools=3.11.1 I'm not able to specify the {{--gc_grace_seconds}} 
option.

I'm using cassandra-tools_3.11.1_all.deb from 
http://dl.bintray.com/apache/cassandra/pool/main/c/cassandra/
{code}
~> sstablemetadata
Usage: sstablemetadata <sstable filenames>

~>  sstablemetadata --gc_grace_seconds=86400 
<path_to_sstable>/lb-80107-big-Data.db
No such file: --gc_grace_seconds=86400
...
{code}

Am I using it wrong or do the new binaries don't contain your patch?

> Estimated droppable tombstones given by sstablemetadata counts tombstones 
> that aren't actually "droppable"
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12208
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12208
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Thanh
>            Assignee: Marcus Eriksson
>            Priority: Minor
>             Fix For: 3.0.9, 3.10
>
>
> => "Estimated droppable tombstones" given by *sstablemetadata* counts 
> tombstones that aren't actually "droppable"
> To be clear, the "Estimated droppable tombstones" calculation counts 
> tombstones that have not yet passed gc_grace_seconds as droppable tombstones, 
> which is unexpected, since such tombstones aren't droppable.
> To observe the problem:
> Create a table using the default gc_grace_seconds (default gc_grace_seconds 
> is 86400 is 1 day).
> Populate the table with a couple of records.
> Do a delete.
> Do a "nodetool flush" to flush the memtable to disk.
> Do an "sstablemetadata <sstable>" to get the metadata of the sstable you just 
> created by doing the flush, and observe that the Estimated droppable 
> tombstones is greater than 0.0 (actual value depends on the total number 
> inserts/updates/deletes that you did before triggered the flush)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to