[
https://issues.apache.org/jira/browse/CASSANDRA-13698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323398#comment-16323398
]
Lerh Chuan Low commented on CASSANDRA-13698:
--------------------------------------------
https://github.com/juiceblender/cassandra/commit/35260ed0c49cb886b71ef0b8ffcd2c8d2e82a73d
I've made a tentative commit that works on trunk.
For {{CompactionsTest}}, what the test method really is testing is that if
there's a single SSTable with droppable tombstones whether it would get
compacted away. Regardless of which compaction strategy one chooses, it will
always do that (all the compaction strategies account for it). It feels like it
was meant to test that {{worthDroppingTombstones}} really worked in a
functional test so I don't think we need to parameterize it for each compaction
strategy, but I'm happy to change it if people think otherwise.
For {{AntiCompactionTest}} then that code path as far as I can tell pays no
attention to what compaction strategy the CFS is actually using, so can be
removed. I did also make one of the tests marked to be ignored
({{antiCompactionSizeTest}} work again - it looks like all that was missing is
that the repair session had to be registered with {{ActiveRepairService}}
first.
Also did a brief refactor rename of {{scts}} to {{stcs}}.
Let me know any thoughts - if you're happy I can look at porting these changes
to branches other than {{trunk}}.
> Reinstate or get rid of unit tests with multiple compaction strategies
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-13698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13698
> Project: Cassandra
> Issue Type: Test
> Components: Testing
> Reporter: Paulo Motta
> Assignee: Lerh Chuan Low
> Priority: Minor
> Labels: lhf
>
> At some point there were (anti-)compaction tests with multiple compaction
> strategy classes, but now it's only tested with {{STCS}}:
> *
> [AnticompactionTest|https://github.com/apache/cassandra/blob/8b3a60b9a7dbefeecc06bace617279612ec7092d/test/unit/org/apache/cassandra/db/compaction/AntiCompactionTest.java#L247]
> *
> [CompactionsTest|https://github.com/apache/cassandra/blob/8b3a60b9a7dbefeecc06bace617279612ec7092d/test/unit/org/apache/cassandra/db/compaction/CompactionsTest.java#L85]
> We should either reinstate these tests or decide they are not important and
> remove the unused parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
