[
https://issues.apache.org/jira/browse/CASSANDRA-9608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325637#comment-16325637
]
Jason Brown commented on CASSANDRA-9608:
----------------------------------------
Nice work, [~snazy]. I'm pretty much +1, except for the
{{AtomicBTreePartition}} change. It is really unfortunate the
{{Unsfae#monitor*}} functions are gone, and I think what you have done by using
a CAS loop is probably the next best thing. My problem is with the
[{{LockSupport#parkNanos}}|https://github.com/apache/cassandra/compare/trunk...snazy:9608-trunk#diff-7246e27576858f45f3f2678b9be03bfeR131]
sleep. I'm not thrilled about the sleep, but I have no better alternative to
it (without chewing up the CPU in a spin lock). That said, I would like to
lower the sleep time duration, or at least make it configurable.
Note: I've only reviewed the code, and have not run it locally yet (will do so
soon)
Also, what c* version(s) are we targeting with these java9 changes?
> Support Java 9
> --------------
>
> Key: CASSANDRA-9608
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9608
> Project: Cassandra
> Issue Type: Task
> Reporter: Robert Stupp
> Assignee: Robert Stupp
> Priority: Minor
>
> This ticket is intended to group all issues found to support Java 9 in the
> future.
> From what I've found out so far:
> * Maven dependency {{com.sun:tools:jar:0}} via cobertura cannot be resolved.
> It can be easily solved using this patch:
> {code}
> - <dependency groupId="net.sourceforge.cobertura"
> artifactId="cobertura"/>
> + <dependency groupId="net.sourceforge.cobertura"
> artifactId="cobertura">
> + <exclusion groupId="com.sun" artifactId="tools"/>
> + </dependency>
> {code}
> * Another issue is that {{sun.misc.Unsafe}} no longer contains the methods
> {{monitorEnter}} + {{monitorExit}}. These methods are used by
> {{o.a.c.utils.concurrent.Locks}} which is only used by
> {{o.a.c.db.AtomicBTreeColumns}}.
> I don't mind to start working on this yet since Java 9 is in a too early
> development phase.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
