[ 
https://issues.apache.org/jira/browse/CASSANDRA-7816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336482#comment-16336482
 ] 

ASF GitHub Bot commented on CASSANDRA-7816:
-------------------------------------------

Github user jasobrown commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/184#discussion_r163399770
  
    --- Diff: src/java/org/apache/cassandra/transport/Server.java ---
    @@ -454,51 +455,32 @@ public static LatestEvent 
forTopologyChange(Event.TopologyChange.Change change,
     
             // We keep track of the latest status change events we have sent 
to avoid sending duplicates
             // since StorageService may send duplicate notifications 
(CASSANDRA-7816, CASSANDRA-8236, CASSANDRA-9156)
    -        private final Map<InetAddress, LatestEvent> latestEvents = new 
ConcurrentHashMap<>();
    +        private final Map<InetAddressAndPort, LatestEvent> latestEvents = 
new ConcurrentHashMap<>();
             // We also want to delay delivering a NEW_NODE notification until 
the new node has set its RPC ready
             // state. This tracks the endpoints which have joined, but not yet 
signalled they're ready for clients
    -        private final Set<InetAddress> endpointsPendingJoinedNotification 
= ConcurrentHashMap.newKeySet();
    -
    -
    -        private static final InetAddress bindAll;
    --- End diff --
    
    hmm, looks like I didn't read that comment. But yes, you are correct, so +1 
here


> Duplicate DOWN/UP Events Pushed with Native Protocol
> ----------------------------------------------------
>
>                 Key: CASSANDRA-7816
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7816
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CQL
>            Reporter: Michael Penick
>            Assignee: Stefania
>            Priority: Minor
>             Fix For: 2.0.15, 2.1.5
>
>         Attachments: 7816-v2.0.txt, tcpdump_repeating_status_change.txt, 
> trunk-7816.txt
>
>
> Added "MOVED_NODE" as a possible type of topology change and also specified 
> that it is possible to receive the same event multiple times.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to