Marcus Eriksson commented on CASSANDRA-13933:

Thanks for the patch [~sumanth.pasupuleti]

I think this looks good in general, small comments;
* I don't think we should declare {{throws CorruptSSTableException}} since it 
is a {{RuntimeException}}
* we could remove the {{throws IOException}} from {{markAndThrow}} (and its 
callers) now since we always throw {{CorruptSSTableException}} instead

We need to apply this to 3.0, 3.11 and trunk, can you provide patches?

> Handle mutateRepaired failure in nodetool verify
> ------------------------------------------------
>                 Key: CASSANDRA-13933
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13933
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Marcus Eriksson
>            Assignee: Sumanth Pasupuleti
>            Priority: Major
>              Labels: lhf
>         Attachments: CASSANDRA-13933-trunk.txt
> See comment here: 
> https://issues.apache.org/jira/browse/CASSANDRA-13922?focusedCommentId=16189875&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16189875

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to