Ariel Weisberg commented on CASSANDRA-14197:

Added a few comments to the commits which you addressed.

Maybe update news.txt to let people know they can do this.

I have a higher level question as to whether people want this functionality? I 
mean I get that when you want to upgrade the sstables you  would like the 
database to handle it and keep retrying until it is done. But why this workflow 
with a property which is a bit wonky? Maybe if you invoke upgradesstables via 
nodetool it should write down the version sstables should be upgraded to in a 
system table and then auto-retry to make it happen.

I guess I question the UI more than the feature since it's buried in as a Java 
property. I also don't know what the inciting incident was that made us think 
that nodetool upgradesstables was not good enough from the ticket description.

> SSTable upgrade should be automatic
> -----------------------------------
>                 Key: CASSANDRA-14197
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14197
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Major
>             Fix For: 4.x
> Upgradesstables should run automatically on node upgrade

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to