[ 
https://issues.apache.org/jira/browse/CASSANDRA-14281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389579#comment-16389579
 ] 

Michael Burman commented on CASSANDRA-14281:
--------------------------------------------

Updated the patch to include merging two reservoir snapshots (with certain 
preassumptions given the use-case inside Cassandra I was intending the feature 
to be used for)

[https://github.com/burmanm/cassandra/commit/c1303f493510e40a4f3d05af74e26d0cdc1c4ea6]

For contention reductions (I'm not going to reduce them more right now) 
aggregating would allow using ThreadLocal instances of LatencyMetrics, but at 
that point we should also get rid of the CAS operations. 

> Reduce contention on DecayingEstimatedHistogramReservoir
> --------------------------------------------------------
>
>                 Key: CASSANDRA-14281
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14281
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Michael Burman
>            Assignee: Michael Burman
>            Priority: Major
>
> Currently, the DecayingEstimatedHistogramReservoir acquires a lock for each 
> update operation, which causes a contention if there are more than one thread 
> updating the histogram. This impacts scalability when using larger machines. 
> We should make it lock-free as much as possible and also avoid a single 
> CAS-update from blocking all the concurrent threads from making an update.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to