[ 
https://issues.apache.org/jira/browse/CASSANDRA-13851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398928#comment-16398928
 ] 

Sam Tunnicliffe commented on CASSANDRA-13851:
---------------------------------------------

Thanks for adding the extra delay for non-seeds, that all LTGM so I've kicked 
off some dtest runs on CircleCI. If they look good I'll commit everything and 
update here.
|3.11|[circleci 
workflow|https://circleci.com/workflow-run/b931896e-6ebb-4513-8f0c-7b6bb8486ee0]|
|trunk|[circleci 
workflow|https://circleci.com/workflow-run/36423e6e-1763-4274-b923-d78d2947a812]|

There were a couple of tweaks I made to the dtest, lmk if those are ok with 
you: 
[https://github.com/beobal/cassandra-dtest/commit/94dee685e10f8819752d7c27533ba8f59b7acb9b]

One small request for future stuff, it makes reviewing iterations on patches 
much easier if you don't rebase/squash once the review is ongoing. Additional 
commits + periodically merging from the base branch makes it a lot simpler to 
pick out the incremental changes during the course of a review. Thanks!

> Allow existing nodes to use all peers in shadow round
> -----------------------------------------------------
>
>                 Key: CASSANDRA-13851
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13851
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Lifecycle
>            Reporter: Kurt Greaves
>            Assignee: Kurt Greaves
>            Priority: Major
>             Fix For: 3.11.x, 4.x
>
>
> In CASSANDRA-10134 we made collision checks necessary on every startup. A 
> side-effect was introduced that then requires a nodes seeds to be contacted 
> on every startup. Prior to this change an existing node could start up 
> regardless whether it could contact a seed node or not (because 
> checkForEndpointCollision() was only called for bootstrapping nodes). 
> Now if a nodes seeds are removed/deleted/fail it will no longer be able to 
> start up until live seeds are configured (or itself is made a seed), even 
> though it already knows about the rest of the ring. This is inconvenient for 
> operators and has the potential to cause some nasty surprises and increase 
> downtime.
> One solution would be to use all a nodes existing peers as seeds in the 
> shadow round. Not a Gossip guru though so not sure of implications.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to