[
https://issues.apache.org/jira/browse/CASSANDRA-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415022#comment-16415022
]
Dinesh Joshi edited comment on CASSANDRA-13653 at 3/27/18 4:52 AM:
-------------------------------------------------------------------
Hi [~djanand], other than [~zznate]'s feedback. I did a quick spot check and
noticed that you're using Apache commons
{{ToStringBuilder.reflectionToString}}. It uses reflection and is not the best
when it comes to performance. I would err on the side of caution and use
{{StringBuilder}} or concat Strings (the compiler should convert them to the
builder equivalent) or at the very least use the builder version of
{{ToStringBuilder}}.
See:
https://antoniogoncalves.org/2015/06/30/who-cares-about-tostring-performance/
was (Author: djoshi3):
Hi [~djanand], other than [~zznate]'s feedback. I did a quick spot check and
noticed that you're using Apache commons
{{ToStringBuilder.reflectionToString}}. It uses reflection and is not the best
when it comes to performance. I would err on the side of caution and use
{{StringBuilder}} or concat Strings (the compiler should convert them to the
builder equivalent) or at the very least use the builder version of
{{ToStringBuilder}}.
> Create meaningful toString() methods
> ------------------------------------
>
> Key: CASSANDRA-13653
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13653
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jeff Jirsa
> Assignee: Jogesh Anand
> Priority: Trivial
> Labels: lhf, low-hanging-fruit
>
> True low-hanging fruit, good for a first-time contributor:
> There are a lot of classes without meaningful {{toString()}} implementations.
> Some of these would be very nice to have for investigating bug reports.
> Some good places to start:
> - CQL3 statements (UpdateStatement, DeleteStatement, etc), QueryOptions, and
> Restrictions
> Some packages not to worry about:
> - Deep internals that don't already have them
> (org.apache.cassandra.db.rows/partitions/etc)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
