[
https://issues.apache.org/jira/browse/CASSANDRA-13529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415113#comment-16415113
]
Dinesh Joshi commented on CASSANDRA-13529:
------------------------------------------
Hi [[email protected]], looks nice. Some more things we can improve
on -
# # {{CASQuery}} - {{bindArgs, fillRandom, random, randomBuffer}} are not
used. Please remove.
# {{PartitionGenerator}} - {{partitionKey}} and {{clusteringComponents}} - use
getters instead of making fields public and return immutable copies of the
lists.
# {{CASQuery::prepareCASDynamicConditionsReadStatement}} - on line 138 instead
of forced typecasting use {{Math.toIntExact}}
# {{CASQuery::prepareCASDynamicConditionsReadStatement}} - on line 135 {{new
HashMap()}} is unchecked assignment. This should be {{new HashMap<>()}}.
# {{keysIndex = new ArrayList<Integer>();}} use {{<>}} operator
# Please add a sample profile in {{tools}} directory and update the in-tree
docs ({{eg. doc/tools/cassandra_stress.rst}})
Nits:
# {{CASQuery - PartitionIterator, Random}} - unused imports. Please remove.
# {{CASQuery::prepareCASDynamicConditionsReadStatement}} -
{{modificationStatement}} do you actually need to initialize this to {{null}}?
# {{QueryUtil::dynamicConditionsExist}} - typo in comment - `differenciate` ->
`differentiate`.
> cassandra-stress light-weight transaction support
> -------------------------------------------------
>
> Key: CASSANDRA-13529
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13529
> Project: Cassandra
> Issue Type: New Feature
> Components: Stress
> Reporter: Jaydeepkumar Chovatia
> Assignee: Jaydeepkumar Chovatia
> Priority: Minor
> Fix For: 4.x
>
> Attachments: 13529.txt, lwttest.yaml
>
>
> It would be nice to have a light-weight transaction support in
> cassandra-stress.
> Although currently in cassandra-stress we can achieve light-weight
> transaction partially by using static conditions like "IF col1 != null" or
> "IF not EXIST".
> If would be ideal to have full fledged light-weight transaction support like
> "IF col1 = ? and col2 = ?". One way to implement is to read values from
> Cassandra and use that in the condition so it will execute all the paxos
> phases in Cassandra.
> Please find git link for the patch:
> https://github.com/apache/cassandra/compare/trunk...jaydeepkumar1984:13529-trunk?expand=1
> ||trunk|
> |[branch|https://github.com/jaydeepkumar1984/cassandra/tree/13529-trunk]|
> |[utests|https://circleci.com/gh/jaydeepkumar1984/cassandra/8]|
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
