[ 
https://issues.apache.org/jira/browse/CASSANDRA-14367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428664#comment-16428664
 ] 

Jason Brown commented on CASSANDRA-14367:
-----------------------------------------

[~dbrosius] In {{TableHistograms}} you used {{Lists.newArrayList}} instead of 
{{Collections.singletonList}}. Any particular reason why?

> prefer Collections.singletonList to Arrays.asList(one_element)
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-14367
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14367
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 4.x
>
>         Attachments: 14367.txt
>
>
> small improvement, but Arrays.asList first creates an array, then wraps it 
> with a collections instance, whereas Collections.singletonList just creates 
> one small (one field) bean instance.
> so a small cut down on garbage generated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to