[
https://issues.apache.org/jira/browse/CASSANDRA-13853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430598#comment-16430598
]
Chris Lohfink commented on CASSANDRA-13853:
-------------------------------------------
A couple things when looking at this. First of all I love the output. A few nit
picks:
* instead of returning -1 can you throw an illegal argument exception with
message if asking for a keyspace that doesnt exist?
* getLeavingNodes etc, have the {{Deprecated}} annotation. That was just
recently added but also used elsewhere so not sure reasoning and if important
to avoid or not [~aweisberg]?
> nodetool describecluster should be more informative
> ---------------------------------------------------
>
> Key: CASSANDRA-13853
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13853
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability, Tools
> Reporter: Jon Haddad
> Assignee: Preetika Tyagi
> Priority: Minor
> Labels: lhf
> Fix For: 4.x
>
> Attachments: cassandra-13853-v2.patch,
> nodetool_describecluster_test.py
>
>
> Additional information we should be displaying:
> * Total node count
> * List of datacenters, RF, with number of nodes per dc, how many are down,
> * Version(s)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
