Marcus Eriksson commented on CASSANDRA-14310:

bq.  is it necessary for ColumnFamilyStore.loadNewSSTables to be synchronized 
on ColumnFamilyStore.class?
hmm, no, looks like it isn't, nice catch, pushed a commit that removes it

Keeping the initialized-check - don't think we should allow refresh before 
fully started

tests: https://circleci.com/gh/krummas/cassandra/tree/marcuse%2F14310
and a dtest: https://github.com/krummas/cassandra-dtest/commits/marcuse/14310

> Don't allow nodetool refresh before cfs is opened
> -------------------------------------------------
>                 Key: CASSANDRA-14310
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14310
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Major
>             Fix For: 3.0.x, 3.11.x, 4.x
> There is a potential deadlock in during startup if nodetool refresh is called 
> while sstables are being opened. We should not allow refresh to be called 
> before everything is initialized.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to