Paulo Motta commented on CASSANDRA-13698:

The patch looks good and the failures look unrelated but I just noticed that 
there are a bunch of other commented-out tests on {{CompactionsTest}} like 
{{testEchoedRow}}, {{testRangeTombstones}}, 
{{testUncheckedTombstoneSizeTieredCompaction}},etc that are like this since 
CASSANDRA-8099. Even though this was not in the original ticket scope, I think 
we should also triage those tests and either remove or restore them. WDYT?

BTW, we should only perform the scts to stcs rename on the trunk patch, since 
this is a change of public interface and there might be external code relying 
on the wrong naming.

> Reinstate or get rid of unit tests with multiple compaction strategies
> ----------------------------------------------------------------------
>                 Key: CASSANDRA-13698
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13698
>             Project: Cassandra
>          Issue Type: Test
>          Components: Testing
>            Reporter: Paulo Motta
>            Assignee: Lerh Chuan Low
>            Priority: Minor
>              Labels: lhf
>         Attachments: 13698-3.0.txt, 13698-3.11.txt, 13698-trunk.txt
> At some point there were (anti-)compaction tests with multiple compaction 
> strategy classes, but now it's only tested with {{STCS}}:
> * 
> [AnticompactionTest|https://github.com/apache/cassandra/blob/8b3a60b9a7dbefeecc06bace617279612ec7092d/test/unit/org/apache/cassandra/db/compaction/AntiCompactionTest.java#L247]
> * 
> [CompactionsTest|https://github.com/apache/cassandra/blob/8b3a60b9a7dbefeecc06bace617279612ec7092d/test/unit/org/apache/cassandra/db/compaction/CompactionsTest.java#L85]
> We should either reinstate these tests or decide they are not important and 
> remove the unused parameter.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to