[ 
https://issues.apache.org/jira/browse/CASSANDRA-14388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440430#comment-16440430
 ] 

Marcus Eriksson edited comment on CASSANDRA-14388 at 4/17/18 5:55 AM:
----------------------------------------------------------------------

https://github.com/krummas/cassandra/commits/marcuse/14388

This patch also replaces the use of {{MAX_COMPACTING_L0}} with 
{{max_threshold}} in {{LeveledManifest}} - not 100% sure this is the best way 
since it will increase the number of sstables needed to run STCS in L0, but at 
the same time it will run actual LCS with more sstables. An alternative would 
be to check if there is more than 32 ({{MAX_COMPACTING_L0}}) sstables in L0, if 
so, grab {{max_threshold}} sstables and run STCS on them, wdyt [~cnlwsu]?


was (Author: krummas):
https://github.com/krummas/cassandra/commits/marcuse/14388

This patch also replaces the use of `MAX_COMPACTING_L0` with `max_threshold` in 
`LeveledManifest` - not 100% sure this is the best way since it will increase 
the number of sstables needed to run STCS in L0, but at the same time it will 
run actual LCS with more sstables. An alternative would be to check if there is 
more than 32 (`MAX_COMPACTING_L0`) sstables in L0, if so, grab `max_threshold` 
sstables and run STCS on them, wdyt [~cnlwsu]?

> Fix setting min/max compaction threshold with LCS
> -------------------------------------------------
>
>                 Key: CASSANDRA-14388
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14388
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Major
>             Fix For: 4.x
>
>
> To be able to actually set max/min_threshold in compaction options we need to 
> remove it from the options map when validating.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to