[
https://issues.apache.org/jira/browse/CASSANDRA-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448077#comment-16448077
]
Sam Tunnicliffe commented on CASSANDRA-14412:
---------------------------------------------
Pushed a branch [here|https://github.com/beobal/cassandra/tree/14412] which
adds back the call to {{SystemKeyspace::snapshotOnVersionChange}}, minus the
call to {{SystemKeyspace::migrateDataDirs}} that it was previously guarding,
but which is genuinely no longer necessary. As snapshots are reasonably cheap
and an upgrade should be a rare event anyway, I've extended the original method
to also snapshot {{system_schema}}.
CI here: https://circleci.com/workflow-run/677d3b4e-85e5-4b90-bb41-309cd4b361f2
> Restore automatic snapshot of system keyspace during upgrade
> ------------------------------------------------------------
>
> Key: CASSANDRA-14412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14412
> Project: Cassandra
> Issue Type: Bug
> Components: Lifecycle
> Reporter: Sam Tunnicliffe
> Assignee: Sam Tunnicliffe
> Priority: Major
> Fix For: 4.0
>
>
> Since 2.2, the installed version is compared with the version persisted in
> system.local (if any) at startup. If these versions differ, the system
> keyspace is snapshotted before proceeding in order to enable a rollback if
> any other issue prevents startup from completing. Although the method to
> perform this check & snapshot is still present in {{SystemKeyspace}}, its
> only callsite was mistakenly removed from {{CassandraDaemon}} in
> CASSANDRA-12716.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
