[ 
https://issues.apache.org/jira/browse/CASSANDRA-14416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452636#comment-16452636
 ] 

Sam Tunnicliffe commented on CASSANDRA-14416:
---------------------------------------------

Hmm, it seems that during CASSANDRA-14134 the initialization of the 
{{CASSANDRA_VERSION_FROM_BUILD}} field in dtest.py got hardcoded to {{'4.0}}', 
so it's not just a matter of adding in the extra check. 
I'll open JIRA shortly to investigate the scope of the problem as there are 
other dtests which use this variable to gate stuff, so I'm curious as to why 
they're not failing on branches other than trunk.

> Remove string formatting lines from hot path
> --------------------------------------------
>
>                 Key: CASSANDRA-14416
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14416
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jeff Jirsa
>            Assignee: Jeff Jirsa
>            Priority: Minor
>              Labels: performance
>             Fix For: 3.11.x, 4.x
>
>
> In the BufferPool, we have a {{NoSpamLogger}} that gets called in some 
> conditions (like when we're at or near the cap in a given pool), which has 
> some string formatting on it. In situations where that log line is invoked, 
> that string formatting gets called before the rate limiting, which becomes 
> expensive. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to