NonSystemKeyspaces jmx attribute needs to return jre list, to work with command 
line tools like jconsole and sjk (swiss java knife)

patch by Edward Ribeiro; reviewed by Chris Lohfink, Mick Semb Wever for 
CASSANDRA-12271


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/72fb86d5
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/72fb86d5
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/72fb86d5

Branch: refs/heads/trunk
Commit: 72fb86d5a585406ae49f3adcbaf6f78ef12295ff
Parents: 78b15bf
Author: Mick Semb Wever <m...@apache.org>
Authored: Tue May 8 14:20:23 2018 +1000
Committer: Mick Semb Wever <m...@apache.org>
Committed: Wed May 9 21:39:07 2018 +1000

----------------------------------------------------------------------
 CHANGES.txt                                               | 1 +
 src/java/org/apache/cassandra/service/StorageService.java | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/72fb86d5/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 5979615..d8d3d6f 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 3.11.3
+ * Don't use guava collections in the non-system keyspace jmx attributes 
(CASSANDRA-12271)
  * Allow existing nodes to use all peers in shadow round (CASSANDRA-13851)
  * Fix cqlsh to read connection.ssl cqlshrc option again (CASSANDRA-14299)
  * Downgrade log level to trace for CommitLogSegmentManager (CASSANDRA-14370)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/72fb86d5/src/java/org/apache/cassandra/service/StorageService.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/service/StorageService.java 
b/src/java/org/apache/cassandra/service/StorageService.java
index f032260..edd8571 100644
--- a/src/java/org/apache/cassandra/service/StorageService.java
+++ b/src/java/org/apache/cassandra/service/StorageService.java
@@ -4774,7 +4774,8 @@ public class StorageService extends 
NotificationBroadcasterSupport implements IE
 
     public List<String> getNonSystemKeyspaces()
     {
-        return 
Collections.unmodifiableList(Schema.instance.getNonSystemKeyspaces());
+        List<String> nonKeyspaceNamesList = new 
ArrayList<>(Schema.instance.getNonSystemKeyspaces());
+        return Collections.unmodifiableList(nonKeyspaceNamesList);
     }
 
     public List<String> getNonLocalStrategyKeyspaces()


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to